feat(ui-position): add available space to position#2552
Merged
Conversation
|
Visual regression report✅ No changes.
Baselines come from the |
ToMESSKa
approved these changes
May 12, 2026
git-nandor
reviewed
May 13, 2026
| ).not.toBe('') | ||
| }) | ||
| expect( | ||
| content.style.getPropertyValue('--ui-position-available-width') |
Contributor
There was a problem hiding this comment.
This could also go inside the waitFor to make the test more stable.
Contributor
Author
There was a problem hiding this comment.
It is inside waitFor now.
git-nandor
requested changes
May 13, 2026
joyenjoyer
force-pushed
the
ui-position-available-space
branch
from
64edddb to
30f705f
Compare
joyenjoyer
force-pushed
the
ui-position-available-space
branch
from
30f705f to
4760277
Compare
git-nandor
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculates and exposes popover's available room (gap between the trigger and the resolved constraint edge) as
--ui-position-available-height/--ui-position-available-widthCSS variables on the content node so consumers can cap their height/width withmax-height: var(--ui-position-available-height). This is needed to make Popover and all other components that use Popover scrollable.Test: go to the Popover docs page and observe the DOM of a Popover during scrolling, value of ui-position-available-height and --ui-position-available-width CSS vars should change.